Fix build with modern cmake/clang toolchain#579
Open
itsme-ranger wants to merge 1 commit into
Open
Conversation
- Bump cmake minimum to 3.10; add CUDAToolkit detection with fallback - Use CUDA::cudart target when CUDAToolkit is available - Remove unused loop variable in lowerer_impl_imperative.cpp - Fix narrowing-conversion warning in tests-tensor_types.cpp - Remove unused countCorrect/countIncorrect in tests-scheduling.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the issues described in #572 with a more conservative set of changes.
Compiler warnings fixed:
src/lower/lowerer_impl_imperative.cpp: remove unused loop variableiand++itest/tests-tensor_types.cpp: fix narrowing-conversion warning (1.0/2.0→static_cast<TypeParam>(1/2))test/tests-scheduling.cpp: remove unusedcountCorrect/countIncorrectvariablesCMake modernization:
CUDAToolkitdetection with fallback to legacyfind_package(CUDA)for backwards compatibilityCUDA::cudartimported target when available; fall back to${CUDA_LIBRARIES}otherwiseapps/tensor_times_vectorminimum from 2.8.12 to 3.10