Add Function#signature for PostgreSQL function identity#207
Merged
Conversation
Fetch argument types via pg_get_function_identity_arguments in the schema dump query and expose a signature method that returns the full PostgreSQL identity (e.g. "add(integer, integer)"). Use signature for equality and ordering so overloaded functions are correctly distinguished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
query so each Fx::Function knows its argument types
(e.g. add(integer, integer) or now_utc())
same name but different arguments are correctly distinguished
Foundational change that both #203 and the dependency sorting
PR can build on.