Added(terminal): add separate italic, bold and boldItalic font files#4813
Added(terminal): add separate italic, bold and boldItalic font files#481311soda11 wants to merge 1 commit intotermux:masterfrom
Conversation
|
even the maintainer doesn't have time for approval |
|
Found out after opening this its not gonna get merged anytime soon due to the rewrite, will try to update this ASAP after that is done though. |
|
May you give the link point to the rewrite? |
Sadly there is not a lot of information on the rewrite as far as im aware. I just know that its going on, and that its the reason why prs arent moving forward, and that the end date is tbd |
… and fix workflow ANDROID_HOME - PR termux#4813: Add separate italic, bold and boldItalic font file support - Refactor TerminalRenderer to support per-style typefaces with fallback - Add font-italic.ttf, font-bold.ttf, font-bold-italic.ttf constants - Update TerminalView to use getter methods instead of direct field access - Update checkForFontAndColors to load all font styles - Fix workflows: Add android-actions/setup-android@v3 step for self-hosted runner Co-authored-by: EduardoC3677 <217669697+EduardoC3677@users.noreply.github.com>
I don't particularly understand why a supposedly ongoing rewrite lasting for almost an entire decade is blocking adding <200 LOC that can easily be excised or changed later. If that's truly why, this is quite possibly some of the worst management skill I have ever seen. |
|
The rewrite has never blocked any changes to terminal code, and various changes have been made in last year or so to it, issue is not having time to review, test and merge the PRs due to work on rewrite, and also works on other parts of termux that were already released in last year or so, which you can view online. I apologize for the delays, but there is only so much I can do at a time. |
|
Thanks for your efforts. If there is anything we as a community can do to offset the burden in any way, please let us know. |
|
Welcome, and thanks for the offer to help, but unfortunately only I can get myself out of the mess of the rewrite I have created for myself, and fixing all the stuff that's broken in Android/JDK. It is coming along however, and once that's done soon, I will look into merging some of these PRs. |
7 participants
Add optional usage of
font-italic.ttffont-bold.ttfandfont-bold-italic.ttffont files.font-italic.ttfand/orfont-bold.ttfis not supplied/empty.font-bold-italic.ttf, the renderer will try to fallback to the supplied italic font (and make it fake bold) or the supplied bold font(and skew it) or the normal font(and skew + fake bold) in that order of priority.Closes #711