Fixed: Improve dark mode support for settings and shared activities#5025
Open
salmon-21 wants to merge 1 commit intotermux:masterfrom
Open
Fixed: Improve dark mode support for settings and shared activities#5025salmon-21 wants to merge 1 commit intotermux:masterfrom
salmon-21 wants to merge 1 commit intotermux:masterfrom
Conversation
Replace hardcoded light-only colors with theme attributes so that SettingsActivity, ReportActivity, TextIOActivity, and message dialogs follow the system dark mode setting. Also update toolbar styling to use a neutral surface color instead of the red brand color, and wrap the toolbar in AppBarLayout for proper elevation shadow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
salmon-21
force-pushed
the
fix/dark-mode-settings-and-toolbar
branch
from
e43d6e3 to
d835c8d
Compare
|
looks better than before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dialog_show_message.xmlandMessageDialogUtils.javawith theme attributessetNightMode()call toTextIOActivity(was missing, unlikeReportActivitywhich already had it)AppBarLayoutfor proper elevation shadowvalues-night/colors.xmlfor dark-appropriate markdown code block background colorsScreenshots
Test plan
use-black-ui=truesetting still worksFixes #2900
🤖 Generated with Claude Code