Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change? Why is it being made?
The
matProps/dataSchemapackage is not used bymatProps, nor is it imported by anyone downstream.But I have already found that it is mildly out-of-date, and kind of hard to keep track when and where to update it. It's NOT a bad package, but will cause a lot of hard-to-automate work over time. And, in the end, I think what people are really going to want is matProps documentation. It will be more helpful to people to read the docs to see what a matProps YAML file can look like; our users don't want to wade into the dataSchema format JSON file to try to figure it out themselves.
SCR Information
Change Type: trivial
One-Sentence Rationale: We should only include code that our users want.
One-line Impact on Requirements: NA
Checklist
docfolder.pyproject.toml.