Fix inconsistent recognition_done_ state on empty pages#4528
Open
eyupcanakman wants to merge 1 commit intotesseract-ocr:mainfrom
Open
Fix inconsistent recognition_done_ state on empty pages#4528eyupcanakman wants to merge 1 commit intotesseract-ocr:mainfrom
eyupcanakman wants to merge 1 commit intotesseract-ocr:mainfrom
Conversation
eyupcanakman
force-pushed
the
fix/recognition-done-empty-page
branch
from
003e38e to
90928a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Recognize() encounters an empty page (no text blocks detected), it sets page_res_ but returns without setting recognition_done_ to true.
Some renderers (hOCR, ALTO, TSV) check page_res_ == nullptr to decide whether to re-run recognition, while others (GetUTF8Text, GetBoxText, GetUNLVText) check !recognition_done_. The second group triggers a redundant Recognize() call on empty pages. If the second pass non-deterministically finds text, later renderers get text while earlier ones (hOCR) return empty output.
Set recognition_done_ = true in the empty-page early-return path, same as the non-empty path. Add a regression test that verifies hOCR, UTF8, and TSV output are all non-null after recognizing a blank image.
Fixes #4112