ci: thaw-lint flagged its own docs (reword matteso1 rule line)#103
Conversation
CONTRIBUTING.md spelled out the archived repo path verbatim while describing the rule that bans it, so thaw-lint (correctly) failed on its own documentation. It passed pre-merge only because the file wasn't yet git-tracked when the linter ran locally (it scans `git ls-files`). Reword to not contain the literal; the rule is self-explanatory.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughThe PR updates archived repository URL guidance, adds Clippy allowances, and changes runtime host registration plus pipelined freeze/restore chunk counting and related tests. ChangesMaintenance and runtime changes
🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
The new lint job runs clippy tree-wide with -D warnings; the never-linted core had 11 lints across thaw-core/thaw-runtime/thaw-cuda-sys (no open PR touches these). All fixed: - machine-applicable autofixes (div_ceil, no-op ops, clone-on-Copy, needless return, redundant parens) via cargo clippy --fix - needless_range_loop -> enumerate over the expected vec - new_without_default on SnapshotHeader::new + assertions_on_constants on the CUDA feature-contract test: both #[allow]'d with a reason, since the constructor's param-growth intent and the compile-time contract check are deliberate clippy --workspace --exclude thaw-py --all-targets -- -D warnings is clean; cargo test green (no behavior change).
One-line fix:
CONTRIBUTING.mddescribed the archived-repo-URL rule by spelling out the banned path verbatim, sothaw-lintfailed on its own documentation on the firstmainrun. It passed pre-merge only because the file wasn'tgit added when the linter ran locally (it scansgit ls-files). Reworded; the rule is self-explanatory.This also lets the new
lintjob's clippy step run in CI for the first time (the prior run stopped at thaw-lint before reaching it).Summary by CodeRabbit