Skip to content

ci: thaw-lint flagged its own docs (reword matteso1 rule line)#103

Merged
matteso1 merged 2 commits into
mainfrom
ci/fix-thaw-lint-self-reference
Jun 25, 2026
Merged

ci: thaw-lint flagged its own docs (reword matteso1 rule line)#103
matteso1 merged 2 commits into
mainfrom
ci/fix-thaw-lint-self-reference

Conversation

@matteso1

@matteso1 matteso1 commented Jun 25, 2026

Copy link
Copy Markdown
Member

One-line fix: CONTRIBUTING.md described the archived-repo-URL rule by spelling out the banned path verbatim, so thaw-lint failed on its own documentation on the first main run. It passed pre-merge only because the file wasn't git added when the linter ran locally (it scans git ls-files). Reworded; the rule is self-explanatory.

This also lets the new lint job's clippy step run in CI for the first time (the prior run stopped at thaw-lint before reaching it).

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidance for project-specific lint rules, including the correct repository location and noting the prior URL is archived/unavailable.
    • Improved formatting for readability.
  • Bug Fixes
    • Improved freeze/restore behavior by using correct “divide-ceiling” chunk calculations across pipeline paths.
    • Fixed device-region handling in the freeze plan and adjusted CUDA-unregister cleanup behavior for non-real registrations.
  • Tests
    • Updated unit tests to match the corrected payload and iteration expectations.

CONTRIBUTING.md spelled out the archived repo path verbatim while
describing the rule that bans it, so thaw-lint (correctly) failed on its
own documentation. It passed pre-merge only because the file wasn't yet
git-tracked when the linter ran locally (it scans `git ls-files`).
Reword to not contain the literal; the rule is self-explanatory.
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
site Ignored Ignored Preview Jun 25, 2026 1:06am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 02aad093-3eda-4690-a5c2-0396de1554fc

📥 Commits

Reviewing files that changed from the base of the PR and between ad3e0a6 and 9738596.

📒 Files selected for processing (4)
  • crates/thaw-core/src/header.rs
  • crates/thaw-cuda-sys/src/lib.rs
  • crates/thaw-runtime/src/backend.rs
  • crates/thaw-runtime/src/pipeline.rs
💤 Files with no reviewable changes (1)
  • crates/thaw-runtime/src/backend.rs
✅ Files skipped from review due to trivial changes (2)
  • crates/thaw-core/src/header.rs
  • crates/thaw-cuda-sys/src/lib.rs

📝 Walkthrough

Walkthrough

The PR updates archived repository URL guidance, adds Clippy allowances, and changes runtime host registration plus pipelined freeze/restore chunk counting and related tests.

Changes

Maintenance and runtime changes

Layer / File(s) Summary
Update archived URL note
CONTRIBUTING.md
The thaw-lint entry now describes archived matteso1 repo URLs as cloning to 404 and points to thaw-ai/thaw as the current location.
Add Clippy allowances
crates/thaw-core/src/header.rs, crates/thaw-cuda-sys/src/lib.rs
SnapshotHeader::new() and the CUDA availability test are annotated to allow the relevant Clippy lints, with comments added around the constant assertion.
Adjust HostRegistration drop path
crates/thaw-runtime/src/backend.rs
HostRegistration::drop no longer returns early for non-real registrations before the CUDA unregister path.
Update pipelined chunk counts
crates/thaw-runtime/src/pipeline.rs
Freeze and restore pipeline code now uses div_ceil for chunk counts, build_freeze_plan records device_region directly, and the related tests were updated for the revised data generation and iteration style.

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • thaw-ai/thaw#94: Introduces the thaw_lint guidance around archived matteso1/thaw URLs that this PR updates in CONTRIBUTING.md.

Poem

🐰 I hopped through links both old and new,
Then counted chunks with div_ceil too.
A Clippy wink, a CUDA tune,
And thawed-up paths beneath the moon.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the fix, but it does not follow the required template and omits How it was verified and the checklist. Rewrite the PR description using the repository template with separate What & why, How it was verified, and Checklist sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: rewording the thaw-lint documentation to avoid the archived matteso1 repo URL.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/fix-thaw-lint-self-reference

Comment @coderabbitai help to get the list of available commands.

The new lint job runs clippy tree-wide with -D warnings; the never-linted
core had 11 lints across thaw-core/thaw-runtime/thaw-cuda-sys (no open PR
touches these). All fixed:
- machine-applicable autofixes (div_ceil, no-op ops, clone-on-Copy,
  needless return, redundant parens) via cargo clippy --fix
- needless_range_loop -> enumerate over the expected vec
- new_without_default on SnapshotHeader::new + assertions_on_constants on
  the CUDA feature-contract test: both #[allow]'d with a reason, since the
  constructor's param-growth intent and the compile-time contract check are
  deliberate
clippy --workspace --exclude thaw-py --all-targets -- -D warnings is clean;
cargo test green (no behavior change).
@matteso1 matteso1 merged commit 8b480b3 into main Jun 25, 2026
8 of 9 checks passed
@matteso1 matteso1 deleted the ci/fix-thaw-lint-self-reference branch June 25, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant