Add Keychron K8 Pro ANSI RGB V3 definition - #2556
Open
Anubhav-Rai wants to merge 1 commit into
Open
Conversation
The K8 Pro ships firmware using VIA protocol v11+, so usevia.app requires a V3 definition, but only a V2 definition exists — the app fails with 'Fetching v3 definition failed' and the board cannot be configured without manually loading a draft. Layout, matrix and custom keycodes match the existing V2 definition (src/keychron/k8_pro/ansi_rgb.json); the Lighting menu mirrors the C2 Pro ANSI RGB V3 definition, whose RGB effect list is identical. Tested on a K8 Pro ANSI RGB (0x3434:0x0280) via the Design tab. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a V3 definition for the Keychron K8 Pro ANSI RGB (
0x3434/0x0280).Current K8 Pro firmware reports VIA protocol >= 11, so usevia.app expects a V3 definition and requests
/definitions/v3/875823744.json. Since only a V2 definition exists for this board, that request is answered by the SPA fallback (HTML with HTTP 200) and the app fails with "Fetching v3 definition failed" — the keyboard cannot be configured at all without manually loading a draft definition in the Design tab. This PR adds the missing V3 file so the board works out of the box again.matrix,customKeycodesandlayoutsare identical to the existing V2 definition (src/keychron/k8_pro/ansi_rgb.json).v3/keychron/c2_pro/c2_pro_ansi_rgb.json(standardid_qmk_rgb_matrix_*channel, 3); the two boards expose an identical RGB effect list.npm run buildpasses locally and the built definition lands indist/v3/875823744.json.Only the ANSI RGB variant is included, as that is the hardware I can test on.
QMK Pull Request
The K8 Pro is not in QMK master — like the other Keychron wireless boards, its source lives in Keychron's fork. This board is already supported by this repository via its V2 definition, and Keychron wireless definitions have been accepted previously (#1735). This PR only adds the V3 counterpart of an already-supported board so that current firmware can load it.
VIA Keymap Pull Request
N/A — no new keyboard is being added; this is the V3 counterpart of an existing supported board.
Checklist
🤖 Generated with Claude Code