Skip to content

Drop --now after restarting gssproxy#3162

Merged
aneta-petrova merged 1 commit intotheforeman:masterfrom
aneta-petrova:SAT-26357_gssproxy-restart
Aug 9, 2024
Merged

Drop --now after restarting gssproxy#3162
aneta-petrova merged 1 commit intotheforeman:masterfrom
aneta-petrova:SAT-26357_gssproxy-restart

Conversation

@aneta-petrova
Copy link
Copy Markdown
Member

https://issues.redhat.com/browse/SAT-26357 requests clarifying a procedure step to restart and enable gssproxy.service.

Doing a bit of archeology, I found the commit that introduced --now to that step: a4be0ab It seems that in case of this particular step, asking users to restart && enable (without --now) might help prevent some raised eyebrows.

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@github-actions
Copy link
Copy Markdown

@aneta-petrova
Copy link
Copy Markdown
Member Author

@ekohl Can you please review? You authored a4be0ab (see the PR description for an explanation).

Copy link
Copy Markdown
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two cents.
The two commands duplicate an action, that's why they raise eyebrows probably.
Suggesting an alternative edit.

@aneta-petrova
Copy link
Copy Markdown
Member Author

My two cents. The two commands duplicate an action, that's why they raise eyebrows probably. Suggesting an alternative edit.

Ah, let's wait for #3149 first, then. Because that introduces changing /etc/gssproxy/http.keytab. Restarting the service will be required. But not just yet, it seems.

@aneta-petrova aneta-petrova marked this pull request as draft July 24, 2024 15:48
@aneta-petrova aneta-petrova marked this pull request as ready for review August 8, 2024 11:19
@aneta-petrova
Copy link
Copy Markdown
Member Author

My two cents. The two commands duplicate an action, that's why they raise eyebrows probably. Suggesting an alternative edit.

Ah, let's wait for #3149 first, then. Because that introduces changing /etc/gssproxy/http.keytab. Restarting the service will be required. But not just yet, it seems.

#3149 is nowhere near merging but based on the comments above, that doesn't have to be a blocker. Clarifying the starting/restarting/enabling of gssproxy.service was requested by an external user in https://issues.redhat.com/browse/SAT-26357 so it would be nice to be able to get the fix in.

@aneta-petrova aneta-petrova requested a review from Lennonka August 8, 2024 11:23
@aneta-petrova aneta-petrova merged commit a2b839f into theforeman:master Aug 9, 2024
aneta-petrova added a commit that referenced this pull request Aug 9, 2024
aneta-petrova added a commit that referenced this pull request Aug 9, 2024
aneta-petrova added a commit that referenced this pull request Aug 9, 2024
aneta-petrova added a commit that referenced this pull request Aug 9, 2024
aneta-petrova added a commit that referenced this pull request Aug 9, 2024
aneta-petrova added a commit that referenced this pull request Aug 9, 2024
aneta-petrova added a commit that referenced this pull request Aug 9, 2024
@aneta-petrova
Copy link
Copy Markdown
Member Author

Merged to "master" and cherry-picked:

ded4218..9d86041 3.11 -> 3.11
85611ea..3160b68 3.10 -> 3.10
bbd2967..76338f5 3.9 -> 3.9
fdabd10..46e9412 3.8 -> 3.8
d995cc3..583a699 3.7 -> 3.7
008b6ae..8f6139c 3.6 -> 3.6
838bd14..227475c 3.5 -> 3.5

@aneta-petrova aneta-petrova deleted the SAT-26357_gssproxy-restart branch January 23, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants