Skip to content

Rework additive mirroring policy for Oracle Linux#4732

Merged
maximiliankolb merged 1 commit intotheforeman:masterfrom
ATIX-AG:oracle_content_additive
Apr 9, 2026
Merged

Rework additive mirroring policy for Oracle Linux#4732
maximiliankolb merged 1 commit intotheforeman:masterfrom
ATIX-AG:oracle_content_additive

Conversation

@maximiliankolb
Copy link
Copy Markdown
Contributor

@maximiliankolb maximiliankolb commented Mar 24, 2026

What changes are you introducing?

This patch adds procedures to set the "Mirroring Policy" and "Retain package versions" for any content.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

It's recommended that users set this for any content for Oracle Linux because Oracle adds packages without removing old versions. This can trigger Pulp OOM issues.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Users report Pulp OOM issues -> recommendation to not keep all packages for content from Oracle.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6 and 7.7)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Mar 24, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026 •
edited
Loading

The PR preview for 78e58b3 is available at theforeman-foreman-documentation-preview-pr-4732.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

maximiliankolb
maximiliankolb commented Mar 24, 2026
View reviewed changes
guides/common/modules/con_uln-repositories.adoc
Copy link
Copy Markdown
Contributor Author

@maximiliankolb maximiliankolb Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a real issue for concept modules? Until now, I thought this rule only applies to procedures.

Copy link
Copy Markdown
Member

@aneta-petrova aneta-petrova Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it is an issue now for concept modules. I raised jhradilek/asciidoctor-dita-vale#177 to clarify.

m-bucher
m-bucher approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical point of view.

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Mar 24, 2026
Lennonka
Lennonka requested changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with the new procedures, but I suggest rethinking the concept module.

guides/common/modules/con_oracle-linux-content.adoc
Copy link
Copy Markdown
Contributor

@Lennonka Lennonka Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving the core of this to Best practices as a new list item? 🤔

Copy link
Copy Markdown
Contributor Author

@maximiliankolb maximiliankolb Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not think about this before but I wish to keep it as is: the OOM problem has been specifically reported for Yum content from Oracle for Oracle Linux because Oracle only adds packages to repos instead of replacing them. This means that you might end up with dozens of package versions of large packages, such as golang-bin.

Copy link
Copy Markdown
Contributor

@Lennonka Lennonka Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the problem is specific to Oracle Linux, but I'm not entirely happy with adding a new heading for it.

@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Apr 7, 2026
@maximiliankolb
Rework additive mirroring policy for Oracle Linux
78e58b3 
This patch adds procedures to set the "Mirroring Policy" and "Retain
package versions" for any content.

It's recommended that users set this for any content for Oracle Linux
because Oracle adds packages without removing old versions. This can
trigger Pulp OOM issues.
@maximiliankolb maximiliankolb force-pushed the oracle_content_additive branch from b104295 to 78e58b3 Compare April 8, 2026 09:24
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Apr 8, 2026
maximiliankolb
maximiliankolb commented Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lena! Rebased to HEAD of "master" and applied all suggestions.

I would like to keep it a separate concept module for now. Ready for re-review.

guides/common/modules/con_oracle-linux-content.adoc
Copy link
Copy Markdown
Contributor Author

@maximiliankolb maximiliankolb Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not think about this before but I wish to keep it as is: the OOM problem has been specifically reported for Yum content from Oracle for Oracle Linux because Oracle only adds packages to repos instead of replacing them. This means that you might end up with dozens of package versions of large packages, such as golang-bin.

Lennonka
Lennonka approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lennonka Lennonka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to rework the whole chapter after your PR, so I'm not blocking it.

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Apr 9, 2026
@maximiliankolb maximiliankolb merged commit 5fe2811 into theforeman:master Apr 9, 2026
10 of 11 checks passed
@maximiliankolb maximiliankolb deleted the oracle_content_additive branch April 9, 2026 07:26
maximiliankolb added a commit that referenced this pull request Apr 9, 2026
@maximiliankolb
Rework additive mirroring policy for Oracle Linux (#4732)
f9fbd96 
This patch adds procedures to set the "Mirroring Policy" and "Retain
package versions" for any content.

It's recommended that users set this for any content for Oracle Linux
because Oracle adds packages without removing old versions. This can
trigger Pulp OOM issues.

(cherry picked from commit 5fe2811)
@maximiliankolb
Copy link
Copy Markdown
Contributor Author

maximiliankolb commented Apr 9, 2026

Thanks Lena.

Merged to "master" and cherry-picked:
a24c485..f9fbd96 3.18 -> 3.18

Should I create a follow-up PR to move this to troubleshooting? As F+K Community, we recommend setting up content for Oracle Linux "correctly", aka. as documented with this PR. As a user, I might ignore this/not follow the docs to setup Yum content/run into this issue after the docs are public & then search for it in troubleshooting.

What do you think @Lennonka and @aneta-petrova ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aneta-petrova aneta-petrova aneta-petrova left review comments

@Lennonka Lennonka Lennonka approved these changes

+2 more reviewers

@m-bucher m-bucher m-bucher approved these changes

@sbernhard sbernhard sbernhard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maximiliankolb @m-bucher @aneta-petrova @Lennonka @sbernhard