Skip to content

Add review requirements for time-sensitive release updates #4746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ogajduse wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Add review requirements for time-sensitive release updates #4746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ As a maintainer, I will:
* Only merge PRs if the Github Actions are green.
* Try to review PRs in a timely manner.
* Keep non-trivial PRs open for at least 24 hours (72 hours if over the weekend) to allow for input from the community.
Examples of trivial PRs: Fixing a typo, fixing markup, or fixing links.
Examples of trivial PRs: Fixing a typo, fixing markup, fixing links, updating release version configuration files (e.g., `web/releases/*.json`).
Time-critical release changes, such as release notes, can be merged without waiting 24 hours, but still require peer review and an ACK.
Non-trivial PRs might not only benefit from additional review but they also represent an opportunity for community members to ask questions and learn.
All PRs, including trivial ones, require peer review and an ACK before merging.

## Pull request checklists

Expand Down