Skip to content

Split Administering hosts into multiple assemblies#4758

Open
aneta-petrova wants to merge 1 commit intotheforeman:masterfrom
aneta-petrova:ustory-administering-hosts
Open

Split Administering hosts into multiple assemblies#4758
aneta-petrova wants to merge 1 commit intotheforeman:masterfrom
aneta-petrova:ustory-administering-hosts

Conversation

@aneta-petrova
Copy link
Copy Markdown
Member

What changes are you introducing?

Introducing several smaller, focused assemblies in place of the existing catch-all "Administering hosts" assembly.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Each assembly should cover a single user story (this is part of the downstream Content Quality Assessment (CQA) initiative.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

I'm not changing anything about the modules themselves, I'm just moving them around.

I used the skill from #4723 for a first draft and I'd say it got about half of the changes right on the first try, so it did a lot of heavy lifting for me, which was very useful.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6 and 7.7)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Apr 8, 2026
@aneta-petrova aneta-petrova force-pushed the ustory-administering-hosts branch from b70be75 to 61922e5 Compare April 8, 2026 20:44
@aneta-petrova aneta-petrova removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Apr 8, 2026
Each assembly should describe a single user story only

Assisted-by: Cursor
@aneta-petrova aneta-petrova force-pushed the ustory-administering-hosts branch from 61922e5 to 6a01de6 Compare April 8, 2026 20:50
@aneta-petrova aneta-petrova marked this pull request as ready for review April 8, 2026 20:57
Copy link
Copy Markdown
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR overall. I made some suggestions.

= Managing host placement and associations

[role="_abstract"]
Use {Project} to link each host to a compute resource, organization, location, and content view environment.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels very vague to me.

What does "link" mean? You cannot just say "move host A from Azure to GCE". Instead, you'd have to redeploy it and delete the old one. That only works well if you have its configuration as code.


[role="_abstract"]
Use {Project} to link each host to a compute resource, organization, location, and content view environment.
Detach host records when hosts move or retire so your host list stays current.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Detach host records when hosts move or retire so your host list stays current.
Detach host records when hosts move or retire so your host list stays current and {Project} no longer tries to manage it.

Unsure about this too. Does detach mean unregister on the Client or mark as unassociated in Foreman/delete in Foreman?

= Managing host snapshots

[role="_abstract"]
You can install the snapshot management plugin and create virtual machine snapshots from {Project} to capture a point-in-time state before risky changes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can install the snapshot management plugin and create virtual machine snapshots from {Project} to capture a point-in-time state before risky changes.
You can install the Snapshot Management plugin and create virtual machine snapshots from {Project} to capture a point-in-time state before risky changes.

[role="_abstract"]
You can review hosts in the {ProjectWebUI} to see them in one place and select the columns you need for daily work.
ifdef::katello,satellite,orcharhino[]
When {RHEL} lifecycle data is available, check it in the same views to plan patches and track compliance.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When {RHEL} lifecycle data is available, check it in the same views to plan patches and track compliance.
When {client-os} lifecycle data is available, check it in the same views to plan patches and track compliance.

This affects all Clients.


include::modules/con_configuring-tracer-and-application-restarts-on-hosts.adoc[]

ifdef::katello,orcharhino,satellite[]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should hide the whole assembly from foreman-el/foreman-deb? Is the concept module on its own of any value?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Lennonka
Copy link
Copy Markdown
Contributor

Lennonka commented Apr 9, 2026

This might be out of scope for this PR, but it would be great if we could move 20. Host status in Foreman under the first chapter Reviewing hosts... Just for your consideration :)

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective Waiting on contributor Requires an action from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants