Convert Apache IPA authentication template to EPP#1172
Open
ekohl wants to merge 2 commits intotheforeman:masterfrom
Open
Convert Apache IPA authentication template to EPP#1172ekohl wants to merge 2 commits intotheforeman:masterfrom
ekohl wants to merge 2 commits intotheforeman:masterfrom
Conversation
This moves the IPA authentication from 4 separate ERB files to a single EPP file. This gives better guarantees because of data types. It's also easier to maintain a single file that gives the complete overview of the feature. It's moved to foreman::config::apache together with the inclusion of required modules. This does make the http_keytab variable a bit uglier.
9 tasks
kenyon
reviewed
Jul 25, 2024
The ipa_manage_sssd block already existed and now the service lives together with the config file management.
ekohl
force-pushed
the
move-ipa-auth-apache
branch
from
924f18a to
f7eb19f
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the IPA authentication from 4 separate ERB files to a single EPP file. This gives better guarantees because of data types. It's also easier to maintain a single file that gives the complete overview of the feature.
It's moved to
foreman::config::apachetogether with the inclusion of required modules. This does make thehttp_keytabvariable a bit uglier.The sssd service definition is moved to avoid duplication. The
ipa_manage_sssdblock already existed and now the service lives together with the config file management.