Dynflow Sidekiq service file can be managed via puppet#1192
Open
highpingblorg wants to merge 8 commits intotheforeman:masterfrom
Open
Dynflow Sidekiq service file can be managed via puppet#1192highpingblorg wants to merge 8 commits intotheforeman:masterfrom
highpingblorg wants to merge 8 commits intotheforeman:masterfrom
Conversation
ekohl
requested changes
Oct 22, 2024
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Loading the full definition is not something I'd want. Systemd has drop in files you can place. Why can't they be used to override only what you need?
Author
|
@ekohl Modified my implementation to use systemd drop in files as requested. If there is anything else I should change, let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1191