Refs #32885: Add puppet user to user_groups only if server or client certificate contains puppet path#938
Merged
ehelms merged 1 commit intotheforeman:masterfrom Jun 25, 2021
Conversation
ehelms
force-pushed
the
puppet-user-create
branch
from
518a1b4 to
3cd393e
Compare
ehelms
changed the title
ekohl
reviewed
May 18, 2021
ehelms
force-pushed
the
puppet-user-create
branch
from
3cd393e to
afaf795
Compare
ekohl
reviewed
Jun 24, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I'd like to see some spec test for this. Also, I think the word "only" is missing in the title to indicate the change. Other than that 👍
ehelms
force-pushed
the
puppet-user-create
branch
from
afaf795 to
b6a7f60
Compare
ehelms
changed the title
Member
Author
|
I added a spec test, let me know if you were also wanting an acceptance test. |
ekohl
approved these changes
Jun 25, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
We should do an installer migration for this as well to remove 'puppet' from the answers file to really benefit from this.
…certificate contains puppet path
ehelms
force-pushed
the
puppet-user-create
branch
from
b6a7f60 to
fa4bdb0
Compare
ehelms
changed the title
ehelms
added a commit
to ehelms/foreman-installer
that referenced
this pull request
Jun 25, 2021
The change theforeman/puppet-foreman#938 introduced dynamically determining if the puppet group needed to be added to the foreman user. This no longer needs to be set explicitly on the foreman::user_groups parameter thus the migration cleans it up if present.
Member
Author
|
Here is the installer PR -- theforeman/foreman-installer#690 |
ehelms
added a commit
to ehelms/foreman-installer
that referenced
this pull request
Jun 25, 2021
The change theforeman/puppet-foreman#938 introduced dynamically determining if the puppet group needed to be added to the foreman user. This no longer needs to be set explicitly on the foreman::user_groups parameter thus the migration cleans it up if present.
ehelms
added a commit
to ehelms/foreman-installer
that referenced
this pull request
Jun 25, 2021
The change theforeman/puppet-foreman#938 introduced dynamically determining if the puppet group needed to be added to the foreman user. This no longer needs to be set explicitly on the foreman::user_groups parameter thus the migration cleans it up if present.
ehelms
added a commit
to ehelms/foreman-installer
that referenced
this pull request
Jun 28, 2021
The change theforeman/puppet-foreman#938 introduced dynamically determining if the puppet group needed to be added to the foreman user. This no longer needs to be set explicitly on the foreman::user_groups parameter thus the migration cleans it up if present.
ehelms
added a commit
to ehelms/foreman-installer
that referenced
this pull request
Jul 7, 2021
The change theforeman/puppet-foreman#938 introduced dynamically determining if the puppet group needed to be added to the foreman user. This no longer needs to be set explicitly on the foreman::user_groups parameter thus the migration cleans it up if present.
ehelms
added a commit
to ehelms/foreman-installer
that referenced
this pull request
Jul 12, 2021
The change theforeman/puppet-foreman#938 introduced dynamically determining if the puppet group needed to be added to the foreman user. This no longer needs to be set explicitly on the foreman::user_groups parameter thus the migration cleans it up if present.
ekohl
pushed a commit
to theforeman/foreman-installer
that referenced
this pull request
Jul 12, 2021
The change theforeman/puppet-foreman#938 introduced dynamically determining if the puppet group needed to be added to the foreman user. This no longer needs to be set explicitly on the foreman::user_groups parameter thus the migration cleans it up if present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for feedback here as I don't know what the exact correct answer is to prevent the following error when setting
puppet::serverto false:It feels like a user of the module should not have to explicitly configure the
user_groupsif they are settingpuppet::serverto false and that the module should adjust appropriately.The puppet-foreman_proxy seems to have a similar failure but different approach: https://github.com/theforeman/puppet-foreman_proxy/blob/941e934a4a27a40e7963bc59f6ab5c14fafb82dc/manifests/config.pp#L33