Extend VMWare image provisioning documentation#1523
Extend VMWare image provisioning documentation#1523lbayerlein wants to merge 3 commits intotheforeman:gh-pagesfrom
Conversation
…sh - extend finish information as new bullet point
|
If my way of documentation is ok, I can add it to latest, too. In future, should I do this the other way round? (first latest, then 1.x) |
|
@ezr-ondrej can you please take a look? |
ezr-ondrej
left a comment
There was a problem hiding this comment.
Just a bit of more fancy wording, I suggested some, but not a native speaker, so no hard feelings if you don't agree, but otherwise nice addition, thanks 👍
|
Ok I will do an update to the latest documentation, too. I will take the new fancy words for that :) |
|
What's the status? |
Co-authored-by: Ondřej Ezr <ezrik12@gmail.com>
lzap
left a comment
There was a problem hiding this comment.
Ok lemme squash this, thank you!
|
Okay this needs to be rebased and single commit and the change must be done against the nightly file, can you do that please? diff --git a/_includes/manuals/nightly/5.2.8_cr_vmware.md b/_includes/manuals/nightly/5.2.8_cr_vmware.md
index fcb79a736..12d4ee561 100644
--- a/_includes/manuals/nightly/5.2.8_cr_vmware.md
+++ b/_includes/manuals/nightly/5.2.8_cr_vmware.md
@@ -17,6 +17,7 @@ The same process can also be done using a user_data template. To configure image
* Browse then to the image to be used for provisioning, and ensure that "User Data" is checked
* Associate a user_data template to the host. The template will use cloud-init syntax.
* Note that the images don't need cloudinit installed, as the cloudinit is converted under the hood to a CustomisationSpec object that VMware can process
+* In order to inform foreman about successful build and get the host to "Installed" state in the UI, the provisioned host have to run a finish script. You canThanks! |
Extend VMWare documentation. Image provisioning information without ssh - extend finish information as new bullet point