Simpler execution of committers script#2257
Open
ogajduse wants to merge 3 commits intotheforeman:gh-pagesfrom
Open
Simpler execution of committers script#2257ogajduse wants to merge 3 commits intotheforeman:gh-pagesfrom
ogajduse wants to merge 3 commits intotheforeman:gh-pagesfrom
Conversation
ogajduse
force-pushed
the
fix-committers-script
branch
from
b5294e4 to
82bfa9a
Compare
ekohl
reviewed
Mar 3, 2026
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I don't think I ever ran the committers script via bundle exec and treated the Gemfile as only what's needed to build the website. It adds a fair number of dependencies so I'm not sure I entirely agree with adding it, but I see your point. I don't have a good answer on how to proceed now.
The git gem dependency is only needed for the committers script, not for building the website. The scripts/Gemfile already exists for managing script-specific dependencies. Usage: bundle exec --gemfile=scripts/Gemfile ruby scripts/committers.rb TAG_FROM TAG_TO Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
Author
|
Good point! I've updated the PR to remove the git gem from the main Gemfile. Instead, the script should be run using the existing bundle exec --gemfile=scripts/Gemfile ruby scripts/committers.rb TAG_FROM TAG_TOThis way we keep script dependencies separate from website building dependencies. I've also added usage instructions as comments at the top of the script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script was failing when run directly due to the wrong Ruby interpreter in the shebang.
Changes:
#!/usr/bin/rubyto#!/usr/bin/env rubyto respect the user's Ruby installation (rbenv, rvm, etc.)scripts/GemfileUsage:
bundle exec --gemfile=scripts/Gemfile ruby scripts/committers.rb TAG_FROM TAG_TOThe
gitgem dependency is managed inscripts/Gemfile(not the main Gemfile) to keep script dependencies separate from website building dependencies.