Skip to content

feat(quote): remove per-article and daily quote count limits#4867

Merged
yingshinlee merged 2 commits into
developfrom
feat/quote-remove-count-limits
Jun 23, 2026
Merged

feat(quote): remove per-article and daily quote count limits#4867
yingshinlee merged 2 commits into
developfrom
feat/quote-remove-count-limits

Conversation

@yingshinlee

Copy link
Copy Markdown
Collaborator

拿掉金句的數量限制(搭配 web PR 的金句牆改版)。base = develop。

改動

  • 移除 putQuote 的兩個數量上限:同篇上限(QUOTE_PER_ARTICLE_LIMIT)每日上限(QUOTE_DAILY_LIMIT)
  • 保留:80 字上限、節錄/substring 比對、ARR 授權僅作者、活動文章限定、同句去重
  • 清掉變 dead 的兩個常數與相關 import
  • 更新 quote.test.ts:原本的 cap 測試改成「移除後可一直貼」

驗證

  • ✅ 本機 tsc --noEmit
  • ✅ 對抗式 review 確認範圍正確、未誤刪安全規則

Users may post any number of quotes now. The content rules still apply:
80-char excerpt cap, substring match, ARR author-only, campaign-only, and
same-quote dedup. Drop the now-dead QUOTE_DAILY_LIMIT / QUOTE_PER_ARTICLE_LIMIT
and the matching test assertions.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yingshinlee yingshinlee requested a review from a team as a code owner June 22, 2026 18:28
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.57%. Comparing base (d3c25e4) to head (ced0875).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4867      +/-   ##
===========================================
- Coverage    73.57%   73.57%   -0.01%     
===========================================
  Files         1084     1084              
  Lines        22229    22219      -10     
  Branches      4896     4894       -2     
===========================================
- Hits         16356    16347       -9     
+ Misses        5392     5391       -1     
  Partials       481      481              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yingshinlee yingshinlee merged commit 0076c4c into develop Jun 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant