[Delegations prereq 8] Make snapshot manifest list dynamic, and remove root.json from snapshot#198
Merged
ethan-lowman-dd merged 6 commits intomasterfrom Jan 21, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 1718832028
💛 - Coveralls |
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-7
branch
from
84c43e5 to
e688697
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-8
branch
from
8ef2e3d to
5d7ade5
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-7
branch
from
e688697 to
9c34a3c
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-8
branch
from
5d7ade5 to
469f0f3
Compare
mnm678
previously approved these changes
Jan 7, 2022
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-8
branch
from
469f0f3 to
ff7805c
Compare
asraa
reviewed
Jan 9, 2022
asraa
previously approved these changes
Jan 9, 2022
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-7
branch
from
5c96ea2 to
c8ecd54
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-8
branch
from
ff7805c to
6361964
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-7
branch
from
c8ecd54 to
530e692
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-8
branch
2 times, most recently
from
1bae51d to
d273f14
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-7
branch
from
81b34fc to
a1f2a82
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-8
branch
from
d273f14 to
64ff34e
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-8
branch
from
64ff34e to
e917997
Compare
ethan-lowman-dd
changed the base branch from
ethan.lowman/delegations-prereq-7
to
master
ethan-lowman-dd
dismissed stale reviews from asraa and mnm678
The base branch was changed.
Contributor
Author
|
I reordered the delegations prereq chain so this one can be merged first. |
joshuagl
reviewed
Jan 19, 2022
Member
joshuagl
left a comment
joshuagl
left a comment
There was a problem hiding this comment.
This series looks good, thanks. Minor suggestions on variable name (manifests->metadata) and removing stale comments.
ethan-lowman-dd
changed the title
asraa
approved these changes
Jan 21, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #175, we will update the implementation of
snapshotMetadatato dynamically return delegated targets as well astargets.json, so we prepare for that we're putting the list of metadata files that snapshot pins into a function.We are also opportunistically using this PR to remove
root.jsonfrom snapshot.