Skip to content

fix: Redirect passphrase output to Standard error#343

Merged
joshuagl merged 2 commits intotheupdateframework:masterfrom
elfotografo007:redirect-passphrase-output
Jul 15, 2022
Merged

fix: Redirect passphrase output to Standard error#343
joshuagl merged 2 commits intotheupdateframework:masterfrom
elfotografo007:redirect-passphrase-output

Conversation

@elfotografo007
Copy link
Copy Markdown
Contributor

@elfotografo007 elfotografo007 commented Jul 14, 2022

Signed-off-by: Andrés Torres andrest@vmware.com

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #
Release Notes:

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:
Redirect passphrase output to Standard error so that we can pipe the output of commands requiring passphrases. See #160 (comment) and https://cloud-native.slack.com/archives/C02D577GX54/p1657742840578189

Please verify and check that the pull request fulfills the following requirements:
No tests added as cmd/tuf/main.go has no tests. No docs needed.

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Signed-off-by: Andrés Torres <andrest@vmware.com>
@elfotografo007 elfotografo007 changed the title Redirect passphrase output to Standard error fix: Redirect passphrase output to Standard error Jul 14, 2022
Copy link
Copy Markdown
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@joshuagl joshuagl merged commit 9334b3f into theupdateframework:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants