Skip to content

Migration to Java 25 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ViacheslavKlimov wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Migration to Java 25 #50

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1572c0e
Migrate build configuration from Java 17 to Java 25
ViacheslavKlimov Feb 20, 2026
cb0783e
Upgrade maven-compiler-plugin to 3.13.0 and remove unnecessary -param…
ViacheslavKlimov Feb 20, 2026
b63e27e
Fix bytebuddy version
ViacheslavKlimov Feb 23, 2026
252f526
ThingsBoard version set to 4.0.0
ViacheslavKlimov Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@
# limitations under the License.
#

FROM thingsboard/tb-node:4.3.0.1
FROM thingsboard/tb-node:4.4.0-SNAPSHOT
COPY target/rule-engine-1.0.0-custom-nodes.jar /usr/share/thingsboard/extensions/
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# rule-node-examples
Examples of custom Rule Nodes for ThingsBoard contribution guide

Requires JDK 25+

Unit tests examples for custom rule nodes added as well

To build the project run `mvn clean install`

To build a custom Docker image run `DOCKER_BUILDKIT=0 docker build . -t your_repo/tb-node:4.3.0.1-custom-1`
To build a custom Docker image run `DOCKER_BUILDKIT=0 docker build . -t your_repo/tb-node:4.4.0-SNAPSHOT-custom-1`
15 changes: 12 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<main.dir>${basedir}</main.dir>
<thingsboard.version>4.3.0.1</thingsboard.version>
<lombok.version>1.18.38</lombok.version>
<thingsboard.version>4.4.0-SNAPSHOT</thingsboard.version>
<lombok.version>1.18.40</lombok.version>
<maven.compiler.source>25</maven.compiler.source>
Copy link
Copy Markdown
Member Author

@ViacheslavKlimov ViacheslavKlimov Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low-confidence observation: maven.compiler.source and maven.compiler.target are redundant when the compiler plugin already specifies <release>25</release> (line 195). The --release flag is a superset that sets source level, target level, and boot classpath in one go. Having both shouldn't cause problems, but if they ever drift apart it could lead to confusing build behavior. Consider removing these two properties and relying solely on <release>.

<maven.compiler.target>25</maven.compiler.target>
<guava.version>33.1.0-jre</guava.version>
<spring-boot.version>3.4.10</spring-boot.version>
<commons-io.version>2.16.1</commons-io.version>
Expand Down Expand Up @@ -179,11 +181,12 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.11.0</version>
<configuration>
<release>17</release>
<release>25</release>
<compilerArgs>
<arg>-Xlint:deprecation</arg>
<arg>-Xlint:removal</arg>
<arg>-Xlint:unchecked</arg>
<arg>-parameters</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
Expand All @@ -198,6 +201,12 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${surefire.version}</version>
<configuration>
<argLine>
-XX:+EnableDynamicAgentLoading
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
</argLine>
</configuration>
</plugin>
</plugins>
</pluginManagement>
Expand Down