Add executable_path to browser jobs - #871
Draft
feder-cr wants to merge 1 commit into
Draft
Conversation
Owner
|
Looks good on the surface, feel free to mark as non-draft when you think it's ready. Also add a |
Owner
|
Seems like this is similar to #861, however I like the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional executable_path to browser jobs, so Playwright can launch a custom browser build (for example a fingerprint-real Firefox) instead of the bundled one. browser already selects the engine; this just adds the binary path and defaults to unset, so current behavior is unchanged. Docs updated. Follows up on #869. Browser job tests pass locally.