Skip to content

DBus-proxy: support for BlueZ and multiple agents#215

Merged
brianmcgillion merged 1 commit into
tiiuae:mainfrom
jkuro-tii:bluez-proxy
Apr 27, 2026
Merged

DBus-proxy: support for BlueZ and multiple agents#215
brianmcgillion merged 1 commit into
tiiuae:mainfrom
jkuro-tii:bluez-proxy

Conversation

@jkuro-tii
Copy link
Copy Markdown
Contributor

@jkuro-tii jkuro-tii commented Feb 18, 2026

Description

DBus Proxy:

  • Added support for BlueZ (Bluetooth stack).
  • Enabled handling of multiple DBus agents.
  • Related Issues

Update of the DBus-proxy

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Dependency update
  • Nix configuration change
  • Other (please describe):

Changes Made

  • Added multi agent support for BlueZ and NetworkManager.
  • Enabled registration of multiple agents.
  • Removed the nm-mode parameter and the NM_SECRET_AGENT_XML environment variable.

Testing Done

  • Built locally with nix build .#<package-name>
  • Ran nix flake check (all packages build successfully)
  • Ran nix fmt -- --fail-on-change (formatting check passed)
  • Ran reuse lint (license compliance verified)
  • Tested in Ghaf environment (if applicable)
  • Manual testing performed:
  • bluetoothctl - power on/off, scan on/off/le, connect, disconnect
  • using blueman-applet functions - search, connect, power on/off

Package Impact

Affected packages:

  • None

Screenshots/Logs

Click to expand
<!-- Paste logs or add screenshots here -->

Checklist

  • Code follows project style guidelines (nix fmt passed)
  • SPDX license headers added to all new files
  • Documentation updated (README, inline comments, etc.)
  • No trailing whitespace in modified files
  • Commit messages follow guidelines
  • No breaking changes (or clearly documented if unavoidable)
  • Security implications considered (no secrets, proper validation)
  • Nix best practices followed (no rec, explicit lib. usage)

Additional Notes


Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-rules.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/dbus_proxy.h Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/handlers.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/handlers.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/proxy_core.cpp Fixed
@jkuro-tii jkuro-tii requested a review from vadika February 18, 2026 10:01
@jkuro-tii jkuro-tii self-assigned this Feb 18, 2026
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-rules.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-rules.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-rules.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp
// side, because this was just a registry update for an
// already registered path
g_dbus_method_invocation_return_value(invocation, nullptr);
g_free(unique_agent_path);

Check notice

Code scanning / CodeQL

Short global name Note

Poor global variable name 'i'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo).
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-rules.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-rules.cpp Fixed
Comment thread packages/cpp/dbus-proxy/dbus-proxy/sni/proxy.cpp
Comment thread packages/cpp/dbus-proxy/dbus-proxy/sni/proxy.cpp
Comment thread packages/cpp/dbus-proxy/dbus-proxy/sni/proxy.cpp
@jkuro-tii jkuro-tii requested review from kajusnau and removed request for vunnyso April 16, 2026 07:06
@jkuro-tii jkuro-tii marked this pull request as ready for review April 16, 2026 07:06
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Outdated
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Outdated
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Outdated
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Outdated
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Outdated
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Outdated
@jkuro-tii
Copy link
Copy Markdown
Contributor Author

Draft PR for Ghaf: tiiuae/ghaf#1899

@jkuro-tii jkuro-tii requested a review from enesoztrk April 21, 2026 10:45
@enesoztrk
Copy link
Copy Markdown
Contributor

please, @jkuro-tii push the latest changes you made.

Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp Outdated
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-handling.cpp
Comment thread packages/cpp/dbus-proxy/dbus-proxy/callback-rules.cpp Outdated
Comment thread packages/cpp/dbus-proxy/dbus-proxy/gdbusprivate.h Outdated
Signed-off-by: jkuro-tii <jaroslaw.kurowski@tii.ae>
@brianmcgillion brianmcgillion merged commit 6bb8a72 into tiiuae:main Apr 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants