Skip to content

tools: bump x/tools for Go 1.25 failpoint builds#10583

Open
wuhuizuo wants to merge 1 commit intotikv:feature/release-8.5-materialized-viewfrom
wuhuizuo:fix/pd-x-tools-go125
Open

tools: bump x/tools for Go 1.25 failpoint builds#10583
wuhuizuo wants to merge 1 commit intotikv:feature/release-8.5-materialized-viewfrom
wuhuizuo:fix/pd-x-tools-go125

Conversation

@wuhuizuo
Copy link
Copy Markdown
Contributor

@wuhuizuo wuhuizuo commented Apr 8, 2026

Summary

  • bump golang.org/x/tools from v0.21.1-0.20240508182429-e35e4ccd0d2d to v0.34.0
  • sync the related indirect x/* dependencies in the root module, tools/, and tests/integrations/
  • fix the failpoint build path on Go 1.25 builders

Why

The failing path is the failpoint build flow:

  • make failpoint-enable build failpoint-disable
  • it fails early in install-tools
  • the old golang.org/x/tools crashes on Go 1.25 in internal/tokeninternal with:
    • invalid array length -delta * delta

This PR upgrades x/tools to the minimum known Go 1.25-compatible tag (v0.34.0) so the failpoint compile path can get past install-tools again.

Verification

  • grep '_' tools.go | sed 's/"//g' | awk '{print $2}' | xargs go install with Go 1.25.5
  • cd tools && go list ./...
  • cd tests/integrations && go list ./...

Release note

Fixed failpoint builds on Go 1.25 by upgrading `golang.org/x/tools` and the synced `x/*` tool dependencies needed by the failpoint build path.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 8, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yisaer for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cf5b9d24-d6b8-41d3-aca1-7c131eb26e19

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. dco-signoff: no Indicates the PR's author has not signed dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 8, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 8, 2026

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2026
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo force-pushed the fix/pd-x-tools-go125 branch from b7ebf3e to f617d4f Compare April 8, 2026 12:02
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Apr 8, 2026
@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 8, 2026

/ok-to-test

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 8, 2026

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 8, 2026

/label release-note-none

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 8, 2026

@wuhuizuo: The label(s) release-note-none cannot be applied. These labels are supported: Hacktoberfest, challenge-program, ci-unstable, compatibility-breaker, high-performance, hptc, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.5, needs-cherry-pick-release-9.0-beta.2, release-note, nextgen, wontfix, affects-7.1, affects-7.5, affects-8.1, affects-8.5, may-affects-7.1, may-affects-7.5, may-affects-8.1, may-affects-8.5.

Details

In response to this:

/label release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 8, 2026

/label release-note

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 8, 2026
@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 8, 2026

@Yisaer This PR fixes the Go 1.25 failpoint build breakage in feature/release-8.5-materialized-view. The dependency bump and focused local verification are already in place. Could you help with /ok-to-test, and if the diff looks fine, /approve as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant