tools: bump x/tools for Go 1.25 failpoint builds#10583
tools: bump x/tools for Go 1.25 failpoint builds#10583wuhuizuo wants to merge 1 commit intotikv:feature/release-8.5-materialized-viewfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @wuhuizuo. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
b7ebf3e to
f617d4f
Compare
|
/ok-to-test |
|
@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label release-note-none |
|
@wuhuizuo: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/label release-note |
|
@Yisaer This PR fixes the Go 1.25 failpoint build breakage in |
Summary
golang.org/x/toolsfromv0.21.1-0.20240508182429-e35e4ccd0d2dtov0.34.0x/*dependencies in the root module,tools/, andtests/integrations/Why
The failing path is the failpoint build flow:
make failpoint-enable build failpoint-disableinstall-toolsgolang.org/x/toolscrashes on Go 1.25 ininternal/tokeninternalwith:invalid array length -delta * deltaThis PR upgrades
x/toolsto the minimum known Go 1.25-compatible tag (v0.34.0) so the failpoint compile path can get pastinstall-toolsagain.Verification
grep '_' tools.go | sed 's/"//g' | awk '{print $2}' | xargs go installwith Go1.25.5cd tools && go list ./...cd tests/integrations && go list ./...Release note