[Design][Linear-Attn] Complete GDN prefill manifest contract#1602
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the GatedDeltaNetPrefillFwdOp manifest in linear_attention.yaml by defining input/output shapes, adding layout-dependent shape rules, and specifying source paths and a roofline function. However, the reviewer noted that referencing non-existent source files, classes, and the roofline function in a spec-only manifest can break validation and test runners. It is recommended to revert these fields to placeholders or null until the actual implementation is introduced.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Notes
Validation