Skip to content

[Design][Linear-Attn] Complete GDN prefill manifest contract#1602

Merged
lcy-seso merged 1 commit into
tile-ai:mainfrom
superAngGao:spec/gdn-prefill-contract
Jun 21, 2026
Merged

[Design][Linear-Attn] Complete GDN prefill manifest contract#1602
lcy-seso merged 1 commit into
tile-ai:mainfrom
superAngGao:spec/gdn-prefill-contract

Conversation

@superAngGao

Copy link
Copy Markdown
Collaborator

Summary

  • encode the GatedDeltaNetPrefillFwdOp BHTD/BHSD and BTHD layout shape contracts in the manifest
  • add fixed-rank shape metadata for the manifest tensors
  • fill the planned roofline/source metadata while keeping the entry spec-only

Notes

Validation

  • python scripts/validate_manifest.py

@superAngGao superAngGao requested a review from a team June 21, 2026 14:43
@github-actions github-actions Bot added the design Design decisions and spec-driven architecture label Jun 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GatedDeltaNetPrefillFwdOp manifest in linear_attention.yaml by defining input/output shapes, adding layout-dependent shape rules, and specifying source paths and a roofline function. However, the reviewer noted that referencing non-existent source files, classes, and the roofline function in a spec-only manifest can break validation and test runners. It is recommended to revert these fields to placeholders or null until the actual implementation is introduced.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tileops/manifest/linear_attention.yaml
Comment thread tileops/manifest/linear_attention.yaml
@lcy-seso lcy-seso merged commit 4a54f93 into tile-ai:main Jun 21, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Design decisions and spec-driven architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants