[Feat][Manifest] Promote non-LA code-present ops#1662
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several new operators to the manifest—including FP8 lighting indexer, Top-K selector, grouped GEMM, various RoPE variants, FP8 quantization, dropout, Engram, FFT, and MHC operators—along with their corresponding roofline performance formulas in tileops/perf/formulas.py. The review feedback highlights critical correctness issues in several of the newly added roofline formulas: FP8LightingIndexerOp misses element size scaling for its inputs; FFTC2COp incorrectly calculates bytes due to unsupported complex types in _dtype_itemsize; and both MHCPreOp and MHCPostOp contain severe math errors that enormously overestimate FLOPs and miscalculate memory traffic by omitting dtypes, tensors, or batch dimensions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Promote existing code-present operators into the release-facing manifest surface for the bounded #1660 batch, excluding Linear Attention and Mamba2/SSD work.
This PR adds manifest coverage for:
RopeNeoxPositionIdsOpDropoutOpFP8QuantOp,FP8LightingIndexerOpTopkSelectorOpGroupedGemmOpFFTC2COpMHCPreOp/MHCPostOpIt also adds matching roofline formulas for these promoted entries.
Scope notes
This PR intentionally keeps the current runtime surface as the source of truth and avoids broad API redesigns. In particular:
_infer_output_shapescoverage and manifest-driven benchmark migration are kept as follow-up work. Existing validator warnings in those areas are advisory and do not blockvalidate_manifest.py --strict.bench_manifest_driven: falseto represent the current coverage honestly.Validation
Ran in the TileOpsGov CI Docker image:
docker run --rm --entrypoint /bin/bash --gpus all --ipc host \ -e PYTHONDONTWRITEBYTECODE=1 \ -e PYTHONPYCACHEPREFIX=/tmp/pycache \ -e RUFF_CACHE_DIR=/tmp/ruff-cache \ -v /home/ga/TileOPs-issue1650-wave0:/workspace \ -w /workspace \ ghcr.io/tile-ai/tileops-runner:65dbc98-torch2.10 \ -lc 'python scripts/validate_manifest.py --strict'docker run --rm --entrypoint /bin/bash --gpus all --ipc host \ -e PYTHONDONTWRITEBYTECODE=1 \ -e PYTHONPYCACHEPREFIX=/tmp/pycache \ -e RUFF_CACHE_DIR=/tmp/ruff-cache \ -v /home/ga/TileOPs-issue1650-wave0:/workspace \ -w /workspace \ ghcr.io/tile-ai/tileops-runner:65dbc98-torch2.10 \ -lc 'python -m ruff check tileops/perf/formulas.py'Both passed.
validate_manifest.py --strictreports existing advisory warnings for shape-infer rollout and non-manifest-driven benches, but no hard errors.Closes #1660.
Part of #1650.