[Doc] Update SKILL.md to support editable installs and clarify develo…#2533
[Doc] Update SKILL.md to support editable installs and clarify develo…#2533erhsh wants to merge 1 commit into
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
📝 WalkthroughWalkthroughUpdated the "Editable Installs" section of the tilelang-build skill documentation, removing a warning against ChangesDocumentation update
Estimated code review effort: 1 (Trivial) | ~3 minutes Related PRs: None identified. Suggested labels: documentation Suggested reviewers: None identified. 🐰 A rabbit hops through docs with glee, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.agents/skills/tilelang-build/SKILL.md (1)
76-78: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winClarify the scope of the
PYTHONPATHcomparison.
pip install -e .andPYTHONPATH=$(pwd)both make imports resolve to the local checkout from the repo root, but they are not equivalent beyond import lookup. The current wording reads as if either choice is interchangeable in general, which can confuse contributors about metadata and dependency handling.Suggested wording
- - Because of the above, an editable install and a plain `PYTHONPATH=$(pwd)` import resolve to the same on-disk `./tilelang`. Either is fine; pick based on whether you want pip to manage metadata/deps. + - Because of the above, both approaches resolve imports to the local `./tilelang` when run from the repo root. Use `pip install -e .` when you want pip to manage package metadata/dependencies; use `PYTHONPATH=$(pwd)` only for the lighter-weight import-only workflow.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/tilelang-build/SKILL.md around lines 76 - 78, Clarify in SKILL.md that `pip install -e .` and `PYTHONPATH=$(pwd)` are only equivalent for importing the local `tilelang` checkout from the repo root, not for environment management. Update the wording around the `tilelang/env.py` dev-checkout behavior and the `cmake + PYTHONPATH` note to explicitly say that pip editable installs handle metadata and dependencies, while `PYTHONPATH` only affects import resolution.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.agents/skills/tilelang-build/SKILL.md:
- Around line 76-78: Clarify in SKILL.md that `pip install -e .` and
`PYTHONPATH=$(pwd)` are only equivalent for importing the local `tilelang`
checkout from the repo root, not for environment management. Update the wording
around the `tilelang/env.py` dev-checkout behavior and the `cmake + PYTHONPATH`
note to explicitly say that pip editable installs handle metadata and
dependencies, while `PYTHONPATH` only affects import resolution.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 00e8aeab-323c-4b25-85d1-59e493e4ae47
📒 Files selected for processing (1)
.agents/skills/tilelang-build/SKILL.md
…pment workflow
Updated
SKILL.mdto clarify the development workflow for editable installs.pip install -e .is supported.tilelang/env.py, including where native libraries are loaded from in a dev checkout.C++ style / lint notes