Skip to content

fix(flows): normalize changed_files to absolute paths for incremental flow detection #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itxaiohanglover wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(flows): normalize changed_files to absolute paths for incremental flow detection #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions code_review_graph/flows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,11 @@ def incremental_trace_flows(
if not changed_files:
return 0

# Normalize to absolute paths — git diff returns relative paths but
# the graph stores absolute file_path values (see #569).
import os
changed_files = [os.path.abspath(f) for f in changed_files]

conn = store._conn
changed_file_set = set(changed_files)

Expand Down