Modify doc and init jobs.#225
Merged
Merged
Conversation
pavlelee
requested changes
Jun 16, 2026
pavlelee
left a comment
Collaborator
There was a problem hiding this comment.
发现一个阻塞问题,先不合并:
incubator/adp/charts/deploy-pre-check/templates/job.yaml:184-188新增COS_STS_KEY后,紧跟着模板里原有的孤立value: {{ .Values.global.components.s3.cos.subPath | quote }}会被 YAML 解析成同一个 env item 的重复valuekey,并覆盖COS_STS_KEY的真实值。- 我本地用 PR head 渲染验证过:
--set global.components.s3.cos.stsKey=sts-key后,解析出的COS_STS_KEY不是sts-key,而是public;默认未配置 stsKey 时也会解析成public。这样check.py会误认为已开启 STS 模式,从而跳过 SecretId/SecretKey 校验。
建议移除这行孤立的 value,或把 COS_STS_KEY 放到不会被覆盖的位置,并增加一次渲染解析验证。
Contributor
Author
已经fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.