Skip to content

Fix #110: Implement certificate chain validation for trusted field - #139

Open
ic0ns wants to merge 1 commit into
mainfrom
fix-trusted-ca-validation
Open

Fix #110: Implement certificate chain validation for trusted field#139
ic0ns wants to merge 1 commit into
mainfrom
fix-trusted-ca-validation

Implement certificate chain validation to set trusted field

71d0d65
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Jenkins CI - TLS-Attacker / Jenkins failed Jun 27, 2025 in 48s

Format Check: error in 'sh' step

Format Check / Shell Script

Error in sh step, with arguments mvn spotless:check.

script returned exit code 1
Build log
+ mvn spotless:check
Picked up JAVA_TOOL_OPTIONS: -Dmaven.ext.class.path="/var/lib/jenkins/workspace/_attacker-org_TLS-Scanner_PR-139@tmp/withMaven2efa75d4/pipeline-maven-spy.jar" -Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/var/lib/jenkins/workspace/_attacker-org_TLS-Scanner_PR-139@tmp/withMaven2efa75d4" 
[INFO] [jenkins-event-spy] Generate /var/lib/jenkins/workspace/_attacker-org_TLS-Scanner_PR-139@tmp/withMaven2efa75d4/maven-spy-20250627-131012-7611333012883463015840.log.tmp ...
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] TLS-Scanner                                                        [pom]
[INFO] TLS-Scanner-Core                                                   [jar]
[INFO] TLS-Client-Scanner                                                 [jar]
[INFO] TLS-Server-Scanner                                                 [jar]
[INFO] 
[INFO] -----------------< de.rub.nds.tls.scanner:tls-scanner >-----------------
[INFO] Building TLS-Scanner 7.1.1                                         [1/4]
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- spotless:2.44.4:check (default-cli) @ tls-scanner ---
[INFO] Index file does not exist. Fallback to an empty index
[INFO] Sorting file /tmp/pom10491683416889347470.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /tmp/pom3399841130059002975.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /tmp/pom13019627050288060885.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /tmp/pom3913633332478171391.xml
[INFO] Pom file is already sorted, exiting
[INFO] Spotless.Pom is keeping 4 files clean - 0 needs changes to be clean, 4 were already clean, 0 were skipped because caching determined they were already clean
[INFO] Spotless.Markdown is keeping 1 files clean - 0 needs changes to be clean, 1 were already clean, 0 were skipped because caching determined they were already clean
[INFO] 
[INFO] --------------< de.rub.nds.tls.scanner:tls-scanner-core >---------------
[INFO] Building TLS-Scanner-Core 7.1.1                                    [2/4]
[INFO]   from TLS-Scanner-Core/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- spotless:2.44.4:check (default-cli) @ tls-scanner-core ---
[INFO] Index file does not exist. Fallback to an empty index
[INFO] Spotless.Java is keeping 133 files clean - 1 needs changes to be clean, 132 were already clean, 0 were skipped because caching determined they were already clean
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for TLS-Scanner 7.1.1:
[INFO] 
[INFO] TLS-Scanner ........................................ SUCCESS [  1.654 s]
[INFO] TLS-Scanner-Core ................................... FAILURE [  2.555 s]
[INFO] TLS-Client-Scanner ................................. SKIPPED
[INFO] TLS-Server-Scanner ................................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.520 s
[INFO] Finished at: 2025-06-27T13:10:16+02:00
[INFO] ------------------------------------------------------------------------
[INFO] [jenkins-event-spy] Generated /var/lib/jenkins/workspace/_attacker-org_TLS-Scanner_PR-139@tmp/withMaven2efa75d4/maven-spy-20250627-131012-7611333012883463015840.log
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.4:check (default-cli) on project tls-scanner-core: The following files had format violations:
[ERROR]     src/test/java/de/rub/nds/tlsscanner/core/probe/certificate/CertificateReportGeneratorTest.java
[ERROR]         @@ -10,7 +10,6 @@
[ERROR]          
[ERROR]          import·static·org.junit.jupiter.api.Assertions.*;
[ERROR]          
[ERROR]         -import·de.rub.nds.tlsscanner.core.trust.TrustAnchorManager;
[ERROR]          import·org.junit.jupiter.api.Test;
[ERROR]          
[ERROR]          class·CertificateReportGeneratorTest·{
[ERROR]         @@ -19,7 +18,7 @@
[ERROR]          ····void·testGenerateReport_BasicTest()·{
[ERROR]          ········//·Very·basic·test·just·to·have·some·coverage
[ERROR]          ········//·Real·testing·would·require·mock·objects·or·actual·certificate·data
[ERROR]         -········
[ERROR]         +
[ERROR]          ········//·This·test·primarily·verifies·the·code·compiles·and·basic·structure·is·correct
[ERROR]          ········assertTrue(true,·"Basic·compilation·test·passes");
[ERROR]          ····}
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :tls-scanner-core

Details

  • Declarative: Checkout SCM (9.5 sec)
    • Clean (5.7 sec)
    • Format Check (8.8 sec)
      Error: script returned exit code 1 - logs
    • Build (1.7 sec)
    • Code Analysis (1.6 sec)
    • Unit Tests (1.7 sec)
    • Integration Tests (1.7 sec)
    • Deploy to Internal Nexus Repository (1.6 sec)
    • Make Github Release (1.6 sec)
    • Public Docker Images (1.6 sec)
    • Internal Docker Images (1.7 sec)
    • Declarative: Post Actions (6.9 sec)