Skip to content

Fix stream-multiple.js: handle undefined index and remove unused callback body #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatrixNeoKozak wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −38
Open

Fix stream-multiple.js: handle undefined index and remove unused callback body #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 19 additions & 38 deletions examples/stream-multiple/stream-multiple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,49 +2,30 @@ var needle = require('needle');
const fs = require('fs-extra')

function stream_multiple(req, res, _urls, stream_dir, index = 0) {
if (index == 0) {
// initial state
if (index == undefined) {
index = 0;
return stream_multiple(req, res, _urls, stream_dir, index);
}

let writeStream;
const uri = _urls[index];

if (index == undefined) {
index = 0;
stream_multiple(req, res, _urls, stream_dir, index);
} else {

writeStream = fs.createWriteStream(`${stream_dir}` + `${index}.jpeg`);

writeStream.on("ready", () => console.log({ msg: `STREAM::WRITE::READY::${index}` }));
writeStream.on("open", () => console.log({ msg: `STREAM::WRITE::OPEN::${index}` }));
writeStream.on("finish", () => console.log({ msg: `STREAM::WRITE::DONE::${index}` }));

writeStream.on('close', () => {
if (index >= _urls.length - 1) {
res.redirect('/');
} else {
stream_multiple(req, res, _urls, stream_dir, index + 1);
}
})

needle
.get(uri, function (error, response) {
if (response.bytes >= 1) {
// you want to kill our servers
}

if (!error && response.statusCode == 200) {
// good
} else {
// then we can retry later
}
})
.pipe(writeStream)
.on('done', function () {
// needle
});
}
writeStream = fs.createWriteStream(`${stream_dir}${index}.jpeg`);

writeStream.on('close', () => {
if (index >= _urls.length - 1) {
res.redirect('/');
} else {
stream_multiple(req, res, _urls, stream_dir, index + 1);
}
});

needle
.get(uri)
.pipe(writeStream)
.on('done', () => {
// stream finished
});
}

module.exports = { stream_multiple }