-
Notifications
You must be signed in to change notification settings - Fork 65
feat(contract-dev): edit upgrade contracts to fit styleguide #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kay-is
wants to merge
11
commits into
main
Choose a base branch
from
upgrade-contracts-style
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−74
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3be783f
feat(contract-dev): edit upgrade contracts to fit styleguide
kay-is 15049bd
fmt
kay-is 629388a
address comments
kay-is f513c25
address remaining comments
kay-is 0dcb50d
address review comments
kay-is 604e694
address review comments
kay-is 20f7cf3
address review comments
kay-is fc3fefb
address review comments
kay-is 6d720a5
Merge branch 'main' into upgrade-contracts-style
aigerimu e188c26
address review comments
kay-is 3aa9f64
Merge branch 'upgrade-contracts-style' of https://github.com/ton-org/…
kay-is File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering about this one technically. The stdlib reference says
contract.setCodePostponed()creates an output action that takes effect only after successful termination, whilecontract.setData()writes storage during the compute phase. If the compute phase succeeds (sosetDatacommits) but the action phase then runs out of Toncoin, I'd expect the storage change to persist while the SETCODE action does not - leaving the contract with the new data schema but still the old code.If that's right, then "the entire transaction is aborted and no state changes from the upgrade are applied" is misleading, and this is actually a fairly sharp footgun worth calling out directly. Could be worth verifying against the actual TVM semantics and either correcting the claim or adding a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
As far as the docs explain it:
"If an action fails (for example, due to a lack of funds), the transaction may revert or skip the action, depending on its mode. For example, mode = 0, flag = 2 means that any errors arising while processing this message during the action phase are ignored."
Depending on these modes, it seems both can be true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that by default, everything is reverted, but setting the
SendIgnoreErrorsflag for a message will ignore the insufficient funds error, and can lead to a situation where the storage is updated, but the code is not.I added a caution aside below to explain it, because it is possible, but not the default behavior.