Skip to content

Fix #11 bounceable mapping #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MIRIK1297 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix #11 bounceable mapping #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e01cd84
add test for correct bounceable/non-bounceable mapping (#11)
MIRIK1297 Apr 24, 2026
3b1e11c
fix: correct bounceable/non-bounceable mapping (#11)
MIRIK1297 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/utils/test_001_detect_address.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import pytest


EXPECTED_RESPONSE_BOUNCEABLE = 'EQCD39VS5jcptHL8vMjEXrzGaRcCVYto7HUn4bpAOg8xqB2N'
EXPECTED_RESPONSE_NONBOUNCEABLE = 'UQCD39VS5jcptHL8vMjEXrzGaRcCVYto7HUn4bpAOg8xqEBI'

TEST_ADDRESSES = [
("EQCD39VS5jcptHL8vMjEXrzGaRcCVYto7HUn4bpAOg8xqB2N",
200),
Expand All @@ -24,4 +27,7 @@ def test_detect_address(api_method_call,
return
data = response.json()
assert data['ok'] == True
result = data['result']
assert result['bounceable']['b64'] == EXPECTED_RESPONSE_BOUNCEABLE
assert result['non_bounceable']['b64'] == EXPECTED_RESPONSE_NONBOUNCEABLE
return
4 changes: 2 additions & 2 deletions ton-http-api/src/converters/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ inline schemas::v2::DetectAddress Convert(const core::DetectAddressResult& value
result.raw_form = value.to_raw_form(true);

block::StdAddress b_addr(value.address);
b_addr.bounceable = false;
b_addr.bounceable = true;
result.bounceable.b64 = b_addr.rserialize(false);
result.bounceable.b64url = b_addr.rserialize(true);

b_addr.bounceable = true;
b_addr.bounceable = false;
result.non_bounceable.b64 = b_addr.rserialize(false);
result.non_bounceable.b64url = b_addr.rserialize(true);
if (value.given_type == "raw_form") {
Expand Down