feat: add tests to pipelines - #60
Open
tsuzukayama wants to merge 1 commit into
Open
Conversation
tsuzukayama
force-pushed
the
feat/github-pipelines
branch
2 times, most recently
from
March 26, 2025 12:43
712d14c to
54a48be
Compare
tsuzukayama
force-pushed
the
feat/github-pipelines
branch
from
March 26, 2025 13:08
54a48be to
982cac1
Compare
hspedro
reviewed
Mar 26, 2025
| @@ -0,0 +1,30 @@ | |||
| name: Test | |||
| on: push | |||
Collaborator
There was a problem hiding this comment.
I'd refine this to run only on pull requests or pushes targeted to main, otherwise, every pull to every repo will trigger (too much cost and runners competing)
on:
pull_request:
branches: [ main ]
push:
branches: [ main ]
tags:
- 'v*.*.*'
Comment on lines
+21
to
+27
| git clone https://github.com/edenhill/librdkafka.git | ||
| cd librdkafka | ||
| ./configure --prefix /usr | ||
| make | ||
| sudo make install | ||
| export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:/usr/lib/pkgconfig/ | ||
| cd .. |
Collaborator
There was a problem hiding this comment.
I'd create a make command for that and call here. Seems like a setup that must be done in the local development as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.