feat(worker): migrate worker and kafka metrics from statsd to prometheus - #64
Open
gmurayama wants to merge 1 commit into
Open
feat(worker): migrate worker and kafka metrics from statsd to prometheus#64gmurayama wants to merge 1 commit into
gmurayama wants to merge 1 commit into
Conversation
vitorbaraujo
self-requested a review
June 2, 2026 17:12
vitorbaraujo
reviewed
Jun 2, 2026
|
|
||
| go func() { | ||
| for range producer.Successes() { | ||
| c.Statsd.Incr("send_message_return", []string{"error:false"}, 1) |
There was a problem hiding this comment.
The new metric is called marathon_kafka_send_message_return_total, is the renaming expected? If that's the case, let's add a document under docs/ listing the changes in metrics and what consumers must do to adapt
| // The metric name uses underscores; the DD OpenMetrics check maps marathon_* → marathon.* | ||
| workerCounter = prometheus.NewCounterVec( | ||
| prometheus.CounterOpts{ | ||
| Name: "marathon_worker_events_total", |
There was a problem hiding this comment.
I didn't find where this metric was configured before. Just to confirm, is the metric name the same for this metric and the one below (marathon_worker_duration_milliseconds)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.