Support compacting prop area#9
Open
aviraxp wants to merge 10 commits into
Open
Conversation
This reverts Change-Id: I663a524670120ee19dfe785aa5f89b3981bdd378
resetprop already fundamentally breaks the existing system property contract, which is "single writer, multiple reader", so it doesn't make sense to spend any effort trying to workaround race conditions. First of all, since we need to use the same code to handle pre API 30 devices, we cannot use the dirty backup area mechanism. After removing that, we cannot rely on the dirty bit of the serial to function correctly, so we skip that too. Finally, we revert property read back to the old wait implementation so that it works on all API levels.
Or else update won't work properly
Co-authored-by: canyie <a1364259@163.com> Co-authored-by: vvb2060 <vvb2060@gmail.com>
This prevents undesirable behavior if apps directly reads prop info from devfs node.
This allows us to keep dictionary tree structure after deleting props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to keep dictionary tree structure after deleting props.