kaizen for diskInfoImpl.Export#172
Open
ushitora-anqou wants to merge 2 commits intomainfrom
Open
Conversation
ushitora-anqou
force-pushed
the
add-post-error-log-for-mount-probe
branch
2 times, most recently
from
4a43c64 to
86ba18a
Compare
ushitora-anqou
changed the title
ushitora-anqou
force-pushed
the
add-post-error-log-for-mount-probe
branch
from
86ba18a to
7f02319
Compare
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
add-post-error-log-for-mount-probe
branch
from
7f02319 to
b8b048c
Compare
molpako
requested changes
Apr 30, 2026
Comment on lines
+51
to
53
| resp, err = http.Post(di.url, "application/json", bytes.NewReader(s)) | ||
| _ = resp.Body.Close() | ||
| if err == nil { |
Contributor
There was a problem hiding this comment.
Can we check err before touching resp.Body.Close()?
resp can be nil on request errors.
Member
Author
There was a problem hiding this comment.
Right. I'll fix this.
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
add-post-error-log-for-mount-probe
branch
from
b8b048c to
700b692
Compare
molpako
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of two commits of kaizen for
diskInfoImpl.Export.