Skip to content

Use EndPoint analysis to discover resource alias groups + use a distinct kind for alias group - #74

Merged
bmahjour merged 1 commit into
torch-spyre:mainfrom
bmahjour:sfu_end_point
Aug 7, 2026
Merged

Use EndPoint analysis to discover resource alias groups + use a distinct kind for alias group#74
bmahjour merged 1 commit into
torch-spyre:mainfrom
bmahjour:sfu_end_point

Conversation

@bmahjour

@bmahjour bmahjour commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

This PR:

  1. Replaces isYieldedBy with a more robust implementation based on EndPoint analysis so alias groups can be identified transitively.
  2. Renames the kind attribute of the sfu group to SFU_Block. This is done to ensure the kind of the exec_unit does not interfere with the kind of the group containing the sfu.

@acgatea1 acgatea1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KFAFSP KFAFSP left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

…nct kind for sfu group

Signed-off-by: Bardia Mahjour <bmahjour@ca.ibm.com>
@bmahjour
bmahjour merged commit 3e7fe4b into torch-spyre:main Aug 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants