fix(pyproject): correct torch ppc64le/s390x exclusion comment - #265
Draft
ashokponkumar wants to merge 2 commits into
Draft
fix(pyproject): correct torch ppc64le/s390x exclusion comment#265ashokponkumar wants to merge 2 commits into
ashokponkumar wants to merge 2 commits into
Conversation
torch-spyre now sources torch via a uv git-source override on ppc64le (from-source build), so hf-adapters doesn't need its own +cpu wheel there; s390x has neither an upstream wheel nor a from-source override, so torch is unresolvable there regardless. Regenerated uv.lock to match. Signed-off-by: Ashok Pon Kumar <ashokponkumar@gmail.com>
ashokponkumar
requested review from
BenjSz,
anubhavjana and
arielge
as code owners
July 31, 2026 17:30
ashokponkumar
marked this pull request as draft
July 31, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch>=2.0; platform_machine not in 's390x, ppc64le'marker itself is unchanged from the prior fix).Test plan
uv lockregenerated cleanly against the corrected comment (no logic change)