Conversation
arielge
changed the title
arielge
marked this pull request as ready for review
August 4, 2026 13:20
7 tasks
BenjSz
reviewed
Aug 5, 2026
| backbone = adapter.get_backbone(model) | ||
| # emb_mult = backbone.embedding_multiplier | ||
| # Falls back to 1.0 for models (Mistral) that don't scale embeddings | ||
| emb_mult = getattr(backbone, "embedding_multiplier", 1.0) |
Contributor
There was a problem hiding this comment.
why was it commented and not rehabilitated?
Contributor
Author
There was a problem hiding this comment.
no reason I can see for keeping it (line 150 covers it completely)
arielge
force-pushed
the
reuse
branch
2 times, most recently
from
August 5, 2026 15:00
4d3580f to
f73c60a
Compare
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.