Maintenance around supported Django, Python and Node package versions - #109
Conversation
and modify classifiers etc including a modern range of wagtail versions.
ca91ba2 to
ed43cc8
Compare
kylebayler
left a comment
There was a problem hiding this comment.
@nickmoreton Nice, thanks for this! This looks great. I've added a couple of questions about bits I don't understand, and a few suggestions to further tighten the tox config for your review.
| djlint==1.23.3 | ||
| pytest==7.0.0 | ||
| pytest-icdiff==0.5 | ||
| syrupy==4.6.0 |
There was a problem hiding this comment.
Yes, the explicit tox deps are needed because tox runs in isolated envs and these test tools aren’t exposed via a package test extra. Without them, a recreated tox env fails on missing pytest, then djlint, then syrupy.
The only unnecessary bit was extras = test, because no such extra exists in pyproject.toml.
There was a problem hiding this comment.
Fair. I'm not a big fan of redefining things like package versions, though switching to pyproject.toml [dependency-groups] feels like overkill.
For now, can you add comments to tox.ini and pypyroject.toml for duplicated packages, e.g.
# in tox.ini
syrupy==4.6.0 # Match version in pyproject.toml
# in pyproject.toml
syrupy = "4.6.0" # Match version in .tox.ini
Co-authored-by: Kyle Bayler <kbayliss@users.noreply.github.com>
Co-authored-by: Kyle Bayler <kbayliss@users.noreply.github.com>
Co-authored-by: Kyle Bayler <kbayliss@users.noreply.github.com>
Co-authored-by: Kyle Bayler <kbayliss@users.noreply.github.com>
Co-authored-by: Kyle Bayler <kbayliss@users.noreply.github.com>
Co-authored-by: Kyle Bayler <kbayliss@users.noreply.github.com>
Co-authored-by: Kyle Bayler <kbayliss@users.noreply.github.com>
Support Reference
Summary
npm outdatedCI compatibility notes
python -m pytestaria-invalid="true"output so existing snapshots remain consistent across supported Django versions.eslintrc.jswitheslint.config.js.nvmrcTesting
poetry run flake8 tbxforms testspoetry run pytestpoetry run tox -lpoetry run tox -e py312-dj42poetry run tox -e py312-dj52npm --cache /private/tmp/tbxforms-npm-cache outdatednpm --cache /private/tmp/tbxforms-npm-cache ls autoprefixer eslint prettier sass vite --depth=0npm run lintnpm run buildIncludes changes made using AI (Codex)