#47 - Setting up wagtail-bynder without BYNDER_VIDEO_MODEL throws a TypeError - #48
Open
SharmaineLim wants to merge 1 commit into
Open
#47 - Setting up wagtail-bynder without BYNDER_VIDEO_MODEL throws a TypeError#48SharmaineLim wants to merge 1 commit into
SharmaineLim wants to merge 1 commit into
Conversation
Currently, editor_js returns None if no BYNDER_VIDEO_MODEL is configured. This None gets fed into a ''.join() which checks that the objects passed in are strings. This triggers a 'TypeError: expected str instance, NoneType found' whenever Wagtail admin editor page is loaded. Relevant links: https://github.com/torchbox/wagtail-bynder/blob/v0.8.1/src/wagtail_bynder/wagtail_hooks.py\#L51 https://github.com/wagtail/wagtail/blob/v7.4/wagtail/admin/templatetags/wagtailadmin_tags.py\#L313 https://docs.python.org/3/library/stdtypes.html\#str.join
Author
|
Since I didn't touch any environment files, I assume the failing test is not introduced by my change. Screenshot: Failed test
I see a similar failure in a different PR. |
Member
|
Hey @SharmaineLim, if you rebase on latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Context
Currently,
editor_jsreturnsNoneif noBYNDER_VIDEO_MODELis configured. ThisNonegets fed into a"".join()which checks that the objects passed in are strings, and triggers aTypeErrorwithexpected str instance, NoneType foundwhenever Wagtail admin editor page is loaded.Screenshot: All page editors on Wagtail admin look like this when no video model is configured
Description of fix
In this PR, we edit
editor_jsto return an empty string instead ofNoneso that we pass the correct object type to"".join().