docs(issues): add specifications for #2121 and #2122 - #2123
Open
josecelano wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Documentation-only update under docs/issues/ that promotes the approved folder-style specifications for #2121 and #2122, and cleans up #2107’s in-folder predecessor drafts in favor of canonical cross-links.
Changes:
- Added new issue specifications for #2121 (typed startup error propagation) and #2122 (additive v1 completed-download retention contract).
- Added an issue-local
manual-verification.mdtemplate for #2122 to record required redacted local evidence (M1–M3). - Updated #2107’s spec to link to the promoted #2121 spec and removed the older in-folder draft documents that were promoted.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/issues/open/2122-expose-unambiguous-download-counter-semantics/manual-verification.md | Adds the mandatory manual verification evidence template for #2122 (M1–M3). |
| docs/issues/open/2122-expose-unambiguous-download-counter-semantics/ISSUE.md | Adds the full folder-style spec for #2122, including plan, acceptance criteria, and verification requirements. |
| docs/issues/open/2121-propagate-bootstrap-startup-errors/ISSUE.md | Adds the full folder-style spec for #2121, defining typed startup error propagation and partial-startup cleanup requirements. |
| docs/issues/open/2107-1978-activate-persistence-free-v3-runtime-composition/ISSUE.md | Updates semantic links to reference the promoted #2121 spec and normalizes formatting in touched sections. |
| docs/issues/open/2107-1978-activate-persistence-free-v3-runtime-composition/download-counter-semantics-investigation.md | Removes the predecessor investigation doc now superseded by the promoted #2122 specification. |
| docs/issues/open/2107-1978-activate-persistence-free-v3-runtime-composition/bootstrap-error-propagation-draft.md | Removes the predecessor draft now superseded by the promoted #2121 specification. |
Suppressed comments (1)
docs/issues/open/2122-expose-unambiguous-download-counter-semantics/ISSUE.md:49
- Grammar nit: "across restart" should be plural (or rephrased) since the text describes behavior over multiple restarts.
When persistent completed statistics are enabled, startup restores the global database aggregate into the same counter and the persistent listener updates the database aggregate. It then represents a historical total across restart.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| Expose separate session and persisted completed-download totals without breaking | ||
| v1 consumers. Establish the `in_session` and `persisted` metric naming | ||
| convention that API v2 will use as its non-ambiguous completed-count contract. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Documentation-only changes under
docs/issues/; no tracker implementation or production behavior changes are included.Validation
linter allTORRUST_GIT_HOOKS_LOG_DIR=.tmp ./contrib/dev-tools/git/hooks/pre-commit.shcargo test --tests --benches --examples --workspace --all-targets --all-featuresRelated to #2121
Related to #2122