feat: support multiple Proxmox instances in single external config - #71
Open
crack-kitty wants to merge 3 commits into
Open
feat: support multiple Proxmox instances in single external config#71crack-kitty wants to merge 3 commits into
crack-kitty wants to merge 3 commits into
Conversation
Use Traefik Go template conditionals to support up to 10 Proxmox servers from a single proxmox.yml. Additional instances activate automatically when their env vars are set in .env.external — no repo changes needed to add new servers. Also silences noisy "Skipped" warnings in traefik-sync-dns for unconfigured conditional instances. Updates pre-commit hook to respect .yamlignore for files with Go template syntax.
ilude
force-pushed
the
feature/multi-instance-proxmox-external
branch
from
May 18, 2026 12:43
b033fe7 to
345997c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Traefik Go template conditionals to support up to 10 Proxmox servers from a single proxmox.yml. Additional instances activate automatically when their env vars are set in .env.external — no repo changes needed to add new servers.
Also silences noisy "Skipped" warnings in traefik-sync-dns for unconfigured conditional instances. Updates pre-commit hook to respect .yamlignore for files with Go template syntax.
more details:
Summary
▎ Note: This is a much improved approach over PR #70 which was closed due to potential breaking changes. This PR is fully backwards compatible — the existing single-instance Proxmox
config is unchanged, and the conditional blocks only activate when env vars are explicitly set.
How to use
Add to .env.external:
PROXMOX2_HOST_NAME=proxmox2
PROXMOX2_ADDRESS=192.168.1.51
Then:
make disable-external proxmox && make enable-external proxmox
make restart-service traefik
make traefik-sync-dns
Test plan