@uppy/transloadit and @uppy/golden-retriever: No Resume Pop up if assembly execution has already started#6278
@uppy/transloadit and @uppy/golden-retriever: No Resume Pop up if assembly execution has already started#6278qxprakash wants to merge 16 commits into
Conversation
…not working post upload
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4860ad9f8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Object.entries(currentUploads).filter(([, upload]) => | ||
| upload.fileIDs.some((id) => { | ||
| const f = files[id] | ||
| return f && !f.progress.complete && !f.error |
There was a problem hiding this comment.
Pruning currentUploads in the postprocess-complete event can remove an upload that is still inside #runUpload(). In Transloadit wait flows, postprocess-complete is emitted as soon as assembly completion is observed, before the postprocessor step fully returns, so this branch can delete currentUploads[uploadID] mid-run. After that, #runUpload() reads getCurrentUpload() as missing, exits early, and upload() can emit a complete payload with empty successful/failed arrays (and skip any remaining postprocessors).
Useful? React with 👍 / 👎.
…to fix-issue-6017
1 participant
This is still WIP , I found few flaws in this which I would like to discuss in a call before moving ahead
This PR fixes #6017
should be merged after #6267
Adds , AssemblyStatus.ok to Status bar
and don't show "Resume" popup in case , where files have been uploaded to assembly and then user refreshes