Skip to content

Restore #6202: Move preact from dependencies into peerDependencies#6341

Open
qxprakash wants to merge 2 commits into
mainfrom
restore/pr-6202
Open

Restore #6202: Move preact from dependencies into peerDependencies#6341
qxprakash wants to merge 2 commits into
mainfrom
restore/pr-6202

Conversation

@qxprakash

@qxprakash qxprakash commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

restore #6202 to 07db03e

mifi added 2 commits March 2, 2026 11:27
Note: this is possibly a breaking change

fixes #6173
Updated package versions from patch to major for various @UPPY packages and moved preact from dependencies to peerDependencies.
@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 07db03e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@uppy/audio Major
@uppy/box Major
@uppy/components Major
@uppy/compressor Major
@uppy/core Major
@uppy/dashboard Major
@uppy/drag-drop Major
@uppy/dropbox Major
@uppy/facebook Major
@uppy/google-drive-picker Major
@uppy/google-drive Major
@uppy/google-photos-picker Major
@uppy/image-editor Major
@uppy/image-generator Major
@uppy/instagram Major
@uppy/onedrive Major
@uppy/provider-views Major
@uppy/react Major
@uppy/screen-capture Major
@uppy/status-bar Major
@uppy/svelte Major
@uppy/unsplash Major
@uppy/url Major
@uppy/utils Major
@uppy/vue Major
@uppy/webcam Major
@uppy/webdav Major
@uppy/zoom Major
uppy Patch
@uppy/remote-sources Major
@uppy/aws-s3 Major
@uppy/companion-client Major
@uppy/drop-target Major
@uppy/form Major
@uppy/golden-retriever Major
@uppy/thumbnail-generator Major
@uppy/transloadit Major
@uppy/tus Major
@uppy/xhr-upload Major
@uppy/angular Major
@uppy/locales Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@qxprakash qxprakash changed the title Restore #6136: Add useGooglePicker Restore #6202: Move preact from dependencies into peerDependencies Jun 17, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07db03e8d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"vitest": "^3.2.4"
},
"peerDependencies": {
"preact": "^10.26.10"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Propagate preact to @uppy/utils dependents

When a user installs a package that depends on @uppy/utils but was not updated, for example @uppy/aws-s3 imports runtime values from @uppy/utils while its manifest still has no preact dependency or peer, Yarn PnP/strict peer resolution leaves @uppy/utils without a provider for this new peer. Importing @uppy/utils also follows the VirtualList re-export that imports preact/hooks, so those non-UI packages can fail at install/runtime after this change. Either keep preact as a dependency here or propagate a preact peer/dependency to the published dependents.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants