Restore #6206: Import Preact from @uppy/utils to guarantee a single version#6344
Restore #6206: Import Preact from @uppy/utils to guarantee a single version#6344qxprakash wants to merge 5 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e353bd43ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "./package.json": "./package.json" | ||
| }, | ||
| "dependencies": { | ||
| "@uppy/utils": "workspace:^", |
There was a problem hiding this comment.
In packages that still compile TSX, adding @uppy/utils does not replace the direct preact runtime dependency: tsconfig.shared.json uses jsx: react-jsx with jsxImportSource: preact, so built files from sources such as packages/@uppy/components/src/FilesGrid.tsx will still contain compiler-generated imports from preact/jsx-runtime. With preact removed from @uppy/components dependencies, consumers using pnpm/Yarn PnP or any install where only @uppy/utils owns preact can fail to resolve those imports at runtime; keep preact as a direct dependency or route the JSX runtime through an exported @uppy/utils subpath before dropping it.
Useful? React with 👍 / 👎.
2 participants
restore #6206 to e353bd4