Miscellaneous improvements for 2026-W03#58
Merged
Merged
Conversation
- Convert "resources" collection to instances of Resource. - Adjust ckan_package_to_mdr() to match. - Add portal_url() method. - Add type hints for known members/attributes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 96.15% 95.85% -0.30%
==========================================
Files 67 69 +2
Lines 3195 3353 +158
==========================================
+ Hits 3072 3214 +142
- Misses 123 139 +16
🚀 New features to boost your workflow:
|
- Add .fetch() method. - Add type hints for known attributes.
- Use in existing modules.
- Adjust test.
- Reduce MODULES_WITH_CLI to internal/non-provider modules.
- Adjust tests. - Type hint tests.
- Use sub-paths from registry in .is_available() call. - Handle ConnectionError/HTTPSConnectionPool max retries exceeded. This may be caused by repeated queries to incorrect URLs.
khaeru
added a commit
that referenced
this pull request
Apr 28, 2026
khaeru
added a commit
that referenced
this pull request
Apr 28, 2026
Contributor
Author
|
Will merge here despite the codecov/patch check failure. Testing the still missing lines requires more extensive features, which can be added in a subsequent PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new CLI command
tdc check-record.This command retrieves the metadata for a given record from the TDC CKAN API and checks/prints some properties of the record. For example:
Filter/ignore the warning due to Replace pkg_resources with importlib.metadata ckan/ckanapi#218. The upstream PR was merged, but the package has not been released since 2024, so the warning still appears.
How to review
tdc check-recordfor some known record IDs.PR checklist