Skip to content

npm: Sanitize shell input#1134

Open
native-api wants to merge 2 commits into
travis-ci:v1from
native-api:npm_sanitize
Open

npm: Sanitize shell input#1134
native-api wants to merge 2 commits into
travis-ci:v1from
native-api:npm_sanitize

Conversation

@native-api

Copy link
Copy Markdown
Contributor

This reverts commit 6f49b25.
Causes test failure, the actual command line is not what this change asserts
@native-api

native-api commented Nov 11, 2019

Copy link
Copy Markdown
Contributor Author

Failure unrelated, caused by the newest rubyzip requiring Ruby 2.4+: https://travis-ci.com/travis-ci/dpl/jobs/255057077#L3167. Jobs with the newer version succeeded.
I would provide a fix for https://github.com/travis-ci/dpl/blob/v1/dpl-elastic_beanstalk.gemspec but instead -- do you really need to test against those old Ruby versions? Workers currently use 2.4 AFAICS.

@tweirtx

tweirtx commented Apr 28, 2020

Copy link
Copy Markdown

Any update on this? This bug is breaking our workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants