Fix GitHub check status failing due to removed URI.escape in Ruby 3.0+#360
Merged
piccadilly-circus merged 2 commits intomasterfrom Apr 9, 2026
Merged
Conversation
Replace URI.escape with CGI.escape in the file_link helper method. URI.escape was removed in Ruby 3.0, causing a NoMethodError that silently breaks GitHub PR check creation for any build with a `gemfile:` matrix key.
The enterprise merge (1d58720) wrapped the build environment updates section in an unless Travis.config.enterprise? conditional, but the test never explicitly set enterprise to false, causing the section to be skipped and the assertion to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URI.escapewithCGI.escapeinfile_linkhelper, fixingNoMethodErroron Ruby 3.0+ that silently kills the entiregithub_check_statusSidekiq taskgemfile:matrix config key (e.g.,gemfile: Gemfile.collate), causingfile_linkto be called during check run output generationenterprise = falsein test setupContext
URI.escapewas removed in Ruby 3.0. Thefile_linkmethod in the check status output helper still used it, causing aNoMethodErrorwhenever a job includes agemfile:key in its matrix config. This crashes the Sidekiq task, so no check run is ever created or updated on GitHub.